chore: add bncode to headers in orders api calls #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,12 +38,14 @@ async function createOrder( | |||
| payload: OrderPayload | |||
| ): Promise<CreateOrderResponse> { | |||
| const basicAuth = btoa(`${getClientID()}`); | |||
| const partnerAttributionId = getPartnerAttributionID(); | |||
|
|
|||
There was a problem hiding this comment.
We dont support Client Side Create Order right. I don't think we ask Merchants to use this at all. This method to CreateOrder can actually be removed from the Component . We can add to just ApproveApplePayment call
There was a problem hiding this comment.
I wasn't sure if this was being used as a placeholder for future use. If it were, we'd want to get the partnerAttributionId in this call.
There was a problem hiding this comment.
Yeah, To give some background context. This was added as a plan to Support Client Side Create Order But it is being decided that we will no longer support Client Side Order Creation not just for ApplePay but across the board.
A Follow up PR would suffice
RatnadeepSimhadri
requested changes
Feb 21, 2023
RatnadeepSimhadri
approved these changes
Feb 22, 2023
|
Merge after Build Passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://paypal.atlassian.net/browse/DTALTPAY-1294
Add bncode (paypal-partner-attribution-id) header so orders API calls (CSPS/CBPS downstream) will receive bncode
With data-partner-attribution-id:
https://sh-pp-observability.us-central1.gcp.dev.paypalinc.com:8000/en-US/app/monitoring-splunk-app/log-vie[…]Amsmaster5int-g_checkoutbuyerplatserv_0
Without data-partner-attribution-id:
https://sh-pp-observability.us-central1.gcp.dev.paypalinc.com:8000/en-US/app/monitoring-splunk-app/log-vie[…]Amsmaster4int-g_checkoutbuyerplatserv_1
Dependent on corresponding xobuyer PR to pass this info to CBPS/CSPS