-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add storybook for CardField components #432
Conversation
We should make sure the code sample can be copy and pasted by the developer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! There is some clean up needed on the warnings and I added some changes for a few areas to fix on naming.
I think one other main area that needs addressing is to remove clientToken
any of these new stories in the PR. It shouldn't be needed for card fields- and could clean up/delete a lot of code
src/stories/payPalCardFields/payPalCardFieldsIndividual.stories.tsx
Outdated
Show resolved
Hide resolved
src/stories/payPalCardFields/payPalCardFieldsIndividual.stories.tsx
Outdated
Show resolved
Hide resolved
src/stories/payPalCardFields/payPalCardFieldsIndividual.stories.tsx
Outdated
Show resolved
Hide resolved
@sebastianfdz and @mchoun could the positioning of the PayPalCardFields component be placed at the top in front of PayPalHostedFields? I would like Card Fields to be found first. |
3ff2fe9
to
20b798b
Compare
Co-authored-by: elizabethmv <40329316+elizabethmv@users.noreply.github.com>
Co-authored-by: elizabethmv <40329316+elizabethmv@users.noreply.github.com>
…es.tsx Co-authored-by: elizabethmv <40329316+elizabethmv@users.noreply.github.com>
….stories.tsx Co-authored-by: elizabethmv <40329316+elizabethmv@users.noreply.github.com>
….stories.tsx Co-authored-by: elizabethmv <40329316+elizabethmv@users.noreply.github.com>
Co-authored-by: elizabethmv <40329316+elizabethmv@users.noreply.github.com>
…es.tsx Co-authored-by: elizabethmv <40329316+elizabethmv@users.noreply.github.com>
Co-authored-by: elizabethmv <40329316+elizabethmv@users.noreply.github.com>
20b798b
to
8fa2294
Compare
Great call! |
Add PayPalCardFields Components Story in Storybook
This PR includes the following Storybook items:
PayPalCardFieldsForm
PayPalNameField
PayPalNumberField
PayPalExpiryField
PayPalCVVField
PayPalCardFieldsProvider
usePayPalCardFields
We include the following for each Story:
Note: Client-id being used in example code is not
test
sincetest
is not set up for ACDC.Implemented code
Source code
Props and types