Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up HTTPClient API not to pass in ask timeout, even implicitly #97

Closed
akara opened this issue Sep 30, 2015 · 0 comments
Closed

Clean up HTTPClient API not to pass in ask timeout, even implicitly #97

akara opened this issue Sep 30, 2015 · 0 comments
Assignees
@akara
Labels
enhancement fixed
Milestone
RELEASE-0.7.X

Comments

@akara
Copy link
Contributor

akara commented Sep 30, 2015

Instead, we should calculate the ask timeout to be marginally larger than the request timeout.
@akara akara self-assigned this Sep 30, 2015
@akara akara added this to the RELEASE-0.7.X milestone Sep 30, 2015
az-qbradley added a commit that referenced this issue Oct 1, 2015
@az-qbradley
Merge pull request #98 from akara/codacy
84c26e9 
#97: Large HttpClient cleanup. …
@akara akara added the fixed label Oct 1, 2015
@akara akara closed this as completed Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akara akara

Labels
enhancement fixed
Projects
None yet
Milestone
RELEASE-0.7.X
Development

No branches or pull requests
1 participant
@akara