Updating countries to include the 83 missing currencies. #2
Conversation
…unctionality to just get the list of currencies.
currency-map.js
Outdated
| "symbolFormat": "CZK {#}" | ||
| }, | ||
| "FIM": { | ||
| "name": "", |
There was a problem hiding this comment.
Just starting looking up some of these with a blank name and they were replaced with the EURO. Should we remove these from the list? I don't think we'd want users to ever select these right? @ahaug1289 how would we handle these from a data perspective?
There was a problem hiding this comment.
Those 4 blank name currencies are all old - and have been replaced by the Euro. They should not be selectable from the survey.
…ion by currency name' functionality.
currency-map.js
Outdated
| "symbolFormat": "CZK {#}" | ||
| }, | ||
| "FIM": { | ||
| "name": "", |
There was a problem hiding this comment.
The extra currencies after zimbabwe seem to check out. The current answervalues that we should no longer be asking for are:
Lithuanian Lita (LTL)
Latvian Lat (LVL)
Estonian Kroon (EEK)
Slovak Koruna (SKK)
Cyprus Pound (CYP)
Maltese Lira (MTL)
Sudanese Dinar (SDD) - Replaced by Sudanese Pound (SSP) - needs to be added
Surinam Guilder (SRG) - Replaced by Surinam Dollar (SRD) - needs to be added
Reuters (SDP)
Slovenian Tolar (SIT)
The two labeled currencies above need to have new answervalues confirmed before they would be save from the survey. I can confirm the values tomorrow.
The rest of the currencies have been replaced by the euro or another currency we already have and can just be removed from the available options.
country-currency-map.js
Outdated
| @@ -26,7 +27,20 @@ function formatCurrency(value, currencyAbbr) { | |||
| return `${value} ${currencyAbbr}`; | |||
| } | |||
|
|
|||
| function getCurrencyList() { | |||
| return currencyMap; | |||
| } | |||
There was a problem hiding this comment.
Should this instead return the list of currency names (and sorted) since that's how it would be displayed in a dropdown?
There was a problem hiding this comment.
Possibly? I didn't know how to order it... alphabetically? Or with usd at top? and I wanted to keep the details about each currency in what we return (symbol, abbr, etc.), so I didn't just want to return a list of strings. But if you think i should change it from a single object to an array of objects, that could be possible.
There was a problem hiding this comment.
Maybe I'm not understanding how this will be used for the currency dropdown. Whatever you think is best, let's go with that 😄
Also added functionality to just get the list of currencies. Total of 174 currencies now.