Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meethod for activate-invoice endpoint #51

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

VuorelaJ-P
Copy link
Contributor

Description

Add method for avtivate-invoice endpoint, https://docs.paytrail.com/#/?id=manually-activating-invoices

Fix #50

tommi-martin
tommi-martin previously approved these changes Sep 27, 2022
Copy link
Contributor

@tommi-martin tommi-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however do you need to add the support for manual invoice activation flag into this pull request as well?

@VuorelaJ-P
Copy link
Contributor Author

Looks good, however do you need to add the support for manual invoice activation flag into this pull request as well?

Good point, thought there already was said thing. Will be added to create payment request.

Default as false, so it needs to be set explicitly on.
Taiteilija
Taiteilija previously approved these changes Oct 6, 2022
Copy link
Contributor

@tommi-martin tommi-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question relating to the setManualInvoiceActivation and getManualInvoiceActivation methods added: Should they be added to some other file instead of the abstractPaymentRequest?
Method names refer to invoices yet when added to abstracts they will be available with all PaymentRequests.

src/Request/AbstractPaymentRequest.php Outdated Show resolved Hide resolved
src/Request/AbstractPaymentRequest.php Show resolved Hide resolved
@loueranta-paytrail loueranta-paytrail merged commit 4ec97a5 into master Nov 15, 2022
@loueranta-paytrail loueranta-paytrail deleted the invoice-activation-endpoint branch November 15, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for manual activation of Walley invoices
4 participants