-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meethod for activate-invoice endpoint #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, however do you need to add the support for manual invoice activation flag into this pull request as well?
Good point, thought there already was said thing. Will be added to create payment request. |
Default as false, so it needs to be set explicitly on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question relating to the setManualInvoiceActivation and getManualInvoiceActivation methods added: Should they be added to some other file instead of the abstractPaymentRequest?
Method names refer to invoices yet when added to abstracts they will be available with all PaymentRequests.
Description
Add method for avtivate-invoice endpoint, https://docs.paytrail.com/#/?id=manually-activating-invoices
Fix #50