Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FMS collate for >9999 files #310

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Fix FMS collate for >9999 files #310

merged 4 commits into from
Sep 3, 2021

Conversation

aidanheerdegen
Copy link
Collaborator

Closes #309

Modified payu.models.fms.get_uncollated_files to support > 9999 files.

Added tests.

@pep8speaks
Copy link

pep8speaks commented Sep 3, 2021

Hello @aidanheerdegen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 19:1: E302 expected 2 blank lines, found 1
Line 25:1: E302 expected 2 blank lines, found 1
Line 28:1: E302 expected 2 blank lines, found 1
Line 38:1: E302 expected 2 blank lines, found 1
Line 47:1: E302 expected 2 blank lines, found 1
Line 50:32: W291 trailing whitespace
Line 57:1: E302 expected 2 blank lines, found 1
Line 62:1: E302 expected 2 blank lines, found 1
Line 64:28: E231 missing whitespace after ','
Line 69:28: E231 missing whitespace after ','
Line 71:28: E231 missing whitespace after ','
Line 76:28: E231 missing whitespace after ','
Line 80:25: E231 missing whitespace after ','
Line 85:28: E231 missing whitespace after ','
Line 90:30: E231 missing whitespace after ','
Line 95:28: E231 missing whitespace after ','
Line 95:55: W292 no newline at end of file

Comment last updated at 2021-09-03 06:59:01 UTC

@coveralls
Copy link

coveralls commented Sep 3, 2021

Coverage Status

Coverage increased (+0.1%) to 42.326% when pulling e9372f3 on issue-309 into 9348acd on master.

@aidanheerdegen
Copy link
Collaborator Author

As this is currently stopping work I will merge shortly, so speak up if anyone (@marshallward @aekiss ?) spots any problems

@aekiss
Copy link
Contributor

aekiss commented Sep 3, 2021

looks fine to me @aidanheerdegen

@aidanheerdegen aidanheerdegen merged commit 6201846 into master Sep 3, 2021
This was referenced Nov 17, 2021
@aidanheerdegen aidanheerdegen deleted the issue-309 branch January 23, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collating regional outputs for core counts exceeding 10,000
4 participants