Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][thread view] display 'non-defining' tags #27

Closed
0x64746b opened this issue Aug 19, 2011 · 1 comment
Closed

[feature][thread view] display 'non-defining' tags #27

0x64746b opened this issue Aug 19, 2011 · 1 comment
Labels

Comments

@0x64746b
Copy link
Collaborator

I'd like to have those tags displayed with every mail that are 'non-defining' for that thread, where 'defining' tags are those that are attached to every mail in that thread. E.g.:

[inbox alot issues] sent       dtk
[inbox alot issues]             |_ pazz
[inbox alot issues] replied        |_ bruce lee
[inbox alot issues] sent                     |_ dtk

with the defining tags being put in brackets and only the other one's to be displayed

@pazz
Copy link
Owner

pazz commented Aug 19, 2011

nice idea. You are aware that in your scenario the result of a thread search for the non-defning tag:replied would
contain the whole thread? In this sense the tag is not non-defining..

I had a prototype once that displayed a messages tags in its summary line widget and it totally cluttered the display in my opinion. But just displaying those that are not shared by all other mails might look nice.

I think one way to do this is like this:

  • add a getter for shared tags in db.Thread. or changing .get_tags() to respect a boolean parameter 'shared'.
    Its a good idea to cache these results, as all msgs will poll it upon display.
  • introducing a non-shared tag getter in message.Message that returns the difference of self.tags and
    self.thread.get_shared_tags()
  • change widget.MessageSummaryWidget (in rebuild() I think) to display TagWidgets for self.msg.get_non_shared_tags()
    like ThreadlineWidget does for the search results

pazz added a commit that referenced this issue Jan 7, 2012
where outstanding means those tats present in the message
but not for every message in its thread.
issue #212, #27
@pazz pazz closed this as completed Jan 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants