Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ngx-chat-messages to use flexbox instead of float #40

Merged
merged 4 commits into from
Sep 3, 2020

Conversation

trampi
Copy link
Contributor

@trampi trampi commented Sep 3, 2020

No description provided.

@coveralls
Copy link

coveralls commented Sep 3, 2020

Pull Request Test Coverage Report for Build 302

  • 3 of 18 (16.67%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 37.202%

Changes Missing Coverage Covered Lines Changed/Added Lines %
projects/pazznetwork/ngx-chat/src/lib/components/chat-message-list/chat-message-list.component.ts 0 1 0.0%
projects/pazznetwork/ngx-chat/src/lib/components/roster-list/roster-list.component.ts 0 1 0.0%
projects/pazznetwork/ngx-chat/src/lib/services/adapters/xmpp/plugins/publish-subscribe.plugin.ts 0 1 0.0%
projects/pazznetwork/ngx-chat/src/lib/components/chat-message-simple/chat-message-simple.component.ts 1 4 25.0%
projects/pazznetwork/ngx-chat/src/lib/components/chat.component.ts 0 4 0.0%
projects/pazznetwork/ngx-chat/src/lib/components/chat-message/chat-message.component.ts 0 5 0.0%
Totals Coverage Status
Change from base Build 294: -0.1%
Covered Lines: 592
Relevant Lines: 1535

💛 - Coveralls

Copy link
Contributor

@CodeBast4rd CodeBast4rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem with the changes.

@trampi trampi merged commit e248b5d into master Sep 3, 2020
@trampi trampi deleted the refactor-chat-flexbox branch September 3, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants