-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improves the ability to get all inline schemas and identify inline object schemas #154
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
- Coverage 99.79% 99.78% -0.01%
==========================================
Files 146 146
Lines 10385 10403 +18
==========================================
+ Hits 10364 10381 +17
- Misses 21 22 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Seems to be an unrelated bit of code dropping coverage not sure how to target it with a test as a summary with two different node structures confuses me tbh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I am not concerned about any 0.01% code change; I generally see these as blips and not something to be concerned about. |
Thanks @daveshanley ready to merge then :D |
@daveshanley very strange I just double checked and there are no conflicts and I see this |
I can squash and merge, but I can't rebase. strange! |
No description provided.