Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improves the ability to get all inline schemas and identify inline object schemas #154

Merged
merged 6 commits into from
Aug 22, 2023

Conversation

TristanSpeakEasy
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (976ca09) 99.79% compared to head (f28d681) 99.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   99.79%   99.78%   -0.01%     
==========================================
  Files         146      146              
  Lines       10385    10403      +18     
==========================================
+ Hits        10364    10381      +17     
- Misses         21       22       +1     
Flag Coverage Δ
unittests 99.78% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
index/extract_refs.go 99.51% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TristanSpeakEasy
Copy link
Contributor Author

Seems to be an unrelated bit of code dropping coverage not sure how to target it with a test as a summary with two different node structures confuses me tbh

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daveshanley
Copy link
Member

I am not concerned about any 0.01% code change; I generally see these as blips and not something to be concerned about.

@TristanSpeakEasy
Copy link
Contributor Author

I am not concerned about any 0.01% code change; I generally see these as blips and not something to be concerned about.

Thanks @daveshanley ready to merge then :D

@daveshanley
Copy link
Member

I can't merge it. Tells me there are conflicts?

Screenshot 2023-08-21 at 1 37 47 PM

@TristanSpeakEasy
Copy link
Contributor Author

I can't merge it. Tells me there are conflicts?

Screenshot 2023-08-21 at 1 37 47 PM

@daveshanley very strange I just double checked and there are no conflicts and I see this
image

@daveshanley
Copy link
Member

I can squash and merge, but I can't rebase. strange!

@daveshanley daveshanley merged commit 74c7a3f into pb33f:main Aug 22, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants