more contrast changes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brittyazel Request my review or mention me when this PR is ready to be merged. |
|
Pr is ready! Happy for a review |
pbaity
reviewed
Feb 3, 2020
|
Did that work? |
This allows it to better match the light theme in style
|
@brittyazel That worked, and your changes look even better than before! Ready to merge? |
|
Yessir! |
|
btw, word on the street is that RocketChat is moving to using the React Native app for all apps, including the web app, moving forward. So this code may end up being non-compatible with a React version in a future update. The good news is the React version has a dark mode built in. |
|
As long as there's a dark mode available, I'll be satisfied. Merging your changes now. |
pbaity
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focusing on small details in the main panel and admin panels, these changes just make a few contrast tweaks to add to the overall look