Bump Grub to 2.12

[danjujan]

Update Grub to 2.12 and fix nasty bugs in the btrfs driver.
Compiles fine with gcc on aarch64 and x86_64. Unfortunately I cannot test if this still compiles with msvc.

[pbatard]

Thanks for this!

But I think you want to make sure that your patch does include the GRUB submodule update as well or else all the build checks are going to fail.

In short, your patch should include a section similar to:

--- a/grub
+++ b/grub
@@ -1 +1 @@
-Subproject commit 710cb5da349d9f03f966b19ec4087912f038fbde
+Subproject commit d9b4638c50b16d4722e66d334e2c1a674b4a45cc

with the SHA-1 updated to the one of current GRUB git repo...
And when you do create the commit, you must make sure that the GRUB patch has not been applied to the submodule, as the SHA-1 won't be found otherwise.

[pbatard]

Oh yeah, and gnu-efi has pretty much be broken ever since the Red-Hat and openSUSE people have decided that it should be aimed at compiling the Linux Shim, so you probably want to switch to using my version of gnu-efi at https://github.com/pbatard/gnu-efi (which is what I am planning to do for the next release).

[danjujan]

Ok, should be fixed. Thank you for the quick reply!

[pbatard]

Hmm, it looks like MinGW on Linux may have changed the way it identifies itself, which appears to be breaking gnu-efi compilation on Linux. I'm probably going to have to fix my version of gnu-efi for that, but I have no idea when I'll get a chance to look into it...

[danjujan]

No problem, take your time. I'll see what I can do in the meantime.

[pbatard]

I think I might have reworked your PR enough so that the builds succeed, so I am going to close this PR with the next push, though I may rework some more if some of the build fail...

[pbatard]

Man, now I remember why I didn't want to bother with zstd with btrfs, because it's really a major PITA, and I had to spend way more time than I'd like fixing this PR. I can tell you one thing though, I am not going to go out of my way supporting more of btrfs in EfiFs than what we currently have, because the cost/benefit simply just not worth it.

For now, I guess not having the Linux/gnu-efi working is fine, as long as we have the other builds (I'll see if I can fix gnu-efi later on), and I would strongly encourage you or anyone interested in btrfs to test the drivers from the artifacts produced by https://github.com/pbatard/EfiFs/actions/runs/9103557282 because that's pretty much what's going to go be in the next EfiFs release (which will happen after EROFS is added to GRUB and I've had a chance to look into producing an EFI driver for it).

[danjujan]

Thank you very much for your efforts. I will try to test the btrfs driver artifact in the next few days and report back to you.

[danjujan]

Btrfs driver still works fine for me.

[pbatard]

Thanks for the report. I will therefore consider this request closed.