Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adb Install Apk #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SeongUgJung
Copy link

Recently, I need this feature.

[Install Apk]

so...It is proto type now. It need to refactor.

I wanna recognize you that someone makes [Install Apk].

since today, I'll refactor, a few day.

@SeongUgJung SeongUgJung mentioned this pull request Sep 17, 2015
@SeongUgJung
Copy link
Author

who had commented about it?

I'm waiting for feedback

@pbreault
Copy link
Owner

Hi @zerobrain ,

Sorry for the delay. This feature looks promising , I tried it and I would definetely include it in the next version. However it doesn't seem to work right now, it did not compile and after fixing the errors, it showed the apk dialog but didn't install anything.

It might be an api difference between the versions of android studio that we are targetting. What is your currend plugin sdk?

@SeongUgJung
Copy link
Author

@pbreault oh. thanks for your reply.
plugin sdk was AS 1.3.x. so I would fix to 1.4.
please wait for additional commit

@SeongUgJung
Copy link
Author

@pbreault I change to support AS 1.4.

@pbreault
Copy link
Owner

pbreault commented Oct 2, 2015

Thank you, I'll check this during the weekend :)

@SeongUgJung
Copy link
Author

👍

@kevinmcampos
Copy link

where is it? :(

@SeongUgJung
Copy link
Author

@kevinmcampos it didn't merge. he has never reviewd this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants