Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify extra time implementation #329

Closed
seananderson opened this issue Mar 27, 2024 · 0 comments
Closed

Simplify extra time implementation #329

seananderson opened this issue Mar 27, 2024 · 0 comments

Comments

@seananderson
Copy link
Member

seananderson commented Mar 27, 2024

  1. Consider longterm moving to a full time vector rather than just specifying extra time elements. In tinyVAST, this is called times. If we move this direction we can soft deprecate extra_time slowly. I'm less considered with this issue, but it's probably easier as a user to worry about specifying a full vector than just the extra time slices. Currently, I'm pretty sure you could just provide a full vector to extra_time and it would ignore time slices that are present in the data, anyways so this mostly about an argument name and how it's described.

  2. Most importantly, remove all the complexity around 'fake' data rows that are added to the end of the real data (with weights of 0) to implement the extra time steps. This seemed like the easiest route initially, but this has proven bug prone and to overly complicate the code base. The extra time slices are only needed in the random effects (spatiotemporal and/or purely time-varying). The data themselves do not need to be touched.

seananderson added a commit that referenced this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant