-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add many missing VDP commands. #10
Conversation
These are the additional commands:
Includes a convenience #define for vdp_gcol as it strays from the usual naming style, but it is easier to type! Note, there is also a critical style/usage fix for vdp_cursor_tab() This differs from how it is used in BASIC - you would expect to do PRINT TAN(X,Y) cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, but please check the call a buffer function.
src/libc/vdp_vdu.c
Outdated
/* Advanced buffered commands (selected) */ | ||
|
||
static VDU_ADV_CMD_ui16 vdu_adv_write_block = { 23, 0, 0xA0, 0xFA00, 0, 0}; | ||
//static VDU_ADV_CMD vdu_adv_call_buffer = { 23, 0, 0xA0, 0xFA00, 1}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a mistake and should be included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did start to add it, but I had no way of testing it as I don't really get the "commands in a VDP buffer" thing.
So, I thought it best I leave it out.
Certainly, I could just add it verbatim from the docs and hope it is correct.
(Would have been better to remove the commented code entirely I guess)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it looks correct. Please add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the head of my main to remove the commented code.
I think probably I would need to create a new PR with all the related "command buffer" VDP commands (1, and 6 though 13) so that they can be used together properly.
That way, this request just adds the graphics advanced buffer commands.
src/libc/vdp_vdu.c
Outdated
VDP_PUTS(vdu_adv_write_block); | ||
} | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the declaration.
to create the buffer commands are not included yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats also a solution. :)
Add commands for many missing VDP commands including those for buffered commands.