Fix bug in return value of strcmp/strncmp #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zilog's implementations of
strcmp
andstrncmp
oddly sign extend the difference of the two characters. This notably has the following problems:unsigned char
. Zilog's behavior is fine if all characters are in the ASCII range and thus differ by no more than 127, but larger differences may be returned with the wrong sign.I was able to fix this (which ends up with better performance in the difference calculation so it's a win-win), and while I was at it, I also optimized the
strncmp
loop a bit. I also improved a couple of the pseudo op replacements from earlier Zilog routine edits.I should also note that on the CEdev side, I fixed the
strncasecmp
errors which had been reported earlier, and also added an implementation forstrcasecmp
, so that should be usable in AgDev.