Deploy Branch Status (September 2022) #32
Conversation
|
Do we need to track down this cron job and relocate it to a new username/credentials? |
|
Seems like the cron job persists, at least for now. We should take it over at some point... What happened with the force push there, @ZLLentz? ... and it's October. Requesting reviews. |
Will was trying to follow update procedure but ended up pushing a commit here manually from a clone of the deploy branch, which broke the cron job pushes from the deploy directory until the unknown commit was overwritten. |
|
Probably we need to replace the cron job with one from one of our users and push-protect this branch a bit better |
| @@ -18476,4 +20333,4 @@ | |||
| "type": "pcdsdevices.happi.containers.GateValve", | |||
| "z": 870.97 | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Should we put this newline back?
| } | |
| } | |
| "ioc_type": "BaslerGigE", | ||
| "ioc_use_evr": "172.21.160.174", | ||
| "ioc_use_evr": "yes", |
There was a problem hiding this comment.
This is correct given the container, but I wonder why it's not a boolean value instead of the current string enforce type
There was a problem hiding this comment.
Looks like a copy-pasta error.
@christina-pino and Aron were working on this. Aron is the ioc_engineer in this entry.
There was a problem hiding this comment.
NVM, I need to open my eyes.
Yeah, this would probably be better as a boolean.
|
Changes seem mostly OK, aside from the things @tangkong pointed out. Merging, a bit past our deadline. Will open a new PR tomorrow |
*** Not to be merged during September ***
This PR can be used to easily see when cron-based pushes to GitHub happen, and allow us an opportunity to review changes prior to merging into master.
(Will Tyler's cron job continue to work? Hmmm)Yes, it will