Deploy Branch Status (October / November 2022) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauer
changed the title
|
Here we are in December but we still rely on Tyler's cron job. Maybe 2023? Edit: and diff is too large to review :( |
|
Comparing to my device_config, the major changes seem to be
lots of devices got moved around so the diff is also unintelligible locally. :( |
tangkong
approved these changes
Dec 1, 2022
That's unfortunate. I'll take a peek locally as well but I suspect everything is fine and this is just to see if there's anyone we need to talk to. |
ZLLentz
approved these changes
Dec 1, 2022
|
I'm going to do the merge now in advance of the next push and bring "figure out how to securely set up fine-grained PATs to set up this sync using one of our users" up higher in my to-do list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** Not to be merged during October ***
This PR can be used to easily see when cron-based pushes to GitHub happen, and allow us an opportunity to review changes prior to merging into master.
(We still have not addressed #33 and we should before the end of this month)