Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Branch Status (Dec 2022 through the current month) #39

Merged
merged 43 commits into from
Aug 17, 2023
Merged

Conversation

klauer
Copy link
Contributor

@klauer klauer commented Feb 16, 2023

*** Not to be merged during October ***

This PR can be used to easily see when cron-based pushes to GitHub happen, and allow us an opportunity to review changes prior to merging into master.

(We still have not addressed #33 and we should before the end of this month)

@@ -11,7 +11,7 @@
"kwargs": {
"name": "{{name}}"
},
"last_edit": "Tue Jan 31 14:23:28 2023",
"last_edit": "Wed Feb 22 15:42:20 2023",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like happi repair updated the last_edit date of every device

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's expected with .save() but perhaps we should have a flag to not update timestamps...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh that's interesting behavior!

@klauer klauer changed the title Deploy Branch Status (Dec 2022, Jan, Feb 2023) Deploy Branch Status (Dec 2022 through the current month) May 8, 2023
Copy link

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL fails if it doesn't recognize the language :/ This seems fine, lots of date updates. happi repair definitely shouldn't save if nothing changed, that's a good thing to note.

@klauer klauer merged commit 9c45681 into master Aug 17, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants