Add imgr and merge iocmanager into one bash file #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ZLLentz
approved these changes
Feb 14, 2022
| HUTCH=${HUTCH:-$(get_hutch_name)} | ||
|
|
||
| # Run if possible | ||
| if [[ "$HUTCH" == "unknown_hutch" ]]; then |
There was a problem hiding this comment.
Stuff like this makes me nervous about knock-on affects of upstream changes to get_hutch_name's output. This also does not catch e.g. --hutch xvs typos, but it probably doesn't need to.
There was a problem hiding this comment.
Yeah, a quick function to check valid hutch names would be nice. Good quick issue for intern :)
Created #106
| if [ `whoami` == "xppopr" ]; then | ||
| window_id=`xdotool search --sync --onlyvisible --name 'IocManager'` | ||
| # Do some window cleanup for xpp | ||
| if [ "$(whoami)" == "xppopr" ]; then |
There was a problem hiding this comment.
This gave me a laugh. Maybe eventually we should have some uniform way of doing this across the various scripts and hutches.
This was referenced Feb 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The bash scripts to access imgr and iocmanager should exist in one place only and engineering_tools is a convenient place because it houses many other commonly used scripts and is already on most peoples's PATHs. This is the first step in moving the scripts from the iocmanager package to engineering_tools. After all hutches have adopted a new release of engineering_tools containing these scripts, I will remove the no-longer-useful bash scripts from the iocmanager package.
How Has This Been Tested?
Interactively.
Shellcheck passes with only SC1091 messages.
Where Has This Been Documented?
Commented each section in both scripts.