MNT: make happi repair not save items that have no changed fields #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange that the multi-backend test is only now failing, after being like that for some time. That failure is unrelated to the changes you made here. |
7 tasks
|
think my github account needs more permissions in this repo, i cant seem to run CI or add reviewers |
|
also sry im setting my PRs as drafts atm b/c still need to fill out descriptions |
nstelter-slac
force-pushed
the
repair_no_changes
branch
from
e091ba7
to
4886ee0
Compare
nstelter-slac
force-pushed
the
repair_no_changes
branch
from
4886ee0
to
067a2c6
Compare
nstelter-slac
force-pushed
the
repair_no_changes
branch
3 times, most recently
from
41257be
to
2d9cda9
Compare
nstelter-slac
changed the title
nstelter-slac
changed the title
nstelter-slac
force-pushed
the
repair_no_changes
branch
2 times, most recently
from
827ac12
to
0f9c3ae
Compare
…json. Added example cfg and instruction to make this easy.
nstelter-slac
force-pushed
the
repair_no_changes
branch
from
0f9c3ae
to
2547efb
Compare
nstelter-slac
changed the title
ZLLentz
reviewed
Sep 24, 2024
ZLLentz
previously approved these changes
Sep 24, 2024
tangkong
previously approved these changes
Sep 24, 2024
nstelter-slac
dismissed stale reviews from tangkong and ZLLentz
via
27fd291
ZLLentz
approved these changes
Sep 25, 2024
tangkong
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it so running
happi repaironly saves an item if it had a field actually changed during the repair process. This stops the last_edit times from being updated on unchanged items.Also, it wasn't immediately clear to me how to use the cli along with the example db.json (so I could try commands on a small example db). So added an example cfg and some instructions to the README to make this easy.
Motivation and Context
closes #324
How Has This Been Tested?
Manually tested and verified, and test case added.
Where Has This Been Documented?
In function's doc string and comments.
Pre-merge checklist
docs/pre-release-notes.shand created a pre-release documentation page