-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: make pre-release notes script check if EDITOR is set #344
MNT: make pre-release notes script check if EDITOR is set #344
Conversation
should prob also update the other pre-release scripts b4 closing issue: https://github.com/search?q=org%3Apcdshub+if+%24%7BEDITOR%7D&type=code |
3cc419a
to
f8b14f2
Compare
actually lets just only also update cookie-cutter for now: pcdshub/cookiecutter-pcds-python#55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sensible and helpful default
Merging once the CI finishes churning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Cookiecutter changes won't immediately propagate to all our packages, but that's ok and doesn't stop this from being mergable
Description
Motivation and Context
closes #326
How Has This Been Tested?
Tested manually
Where Has This Been Documented?
don't think it's necessary for this
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page