-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: fix a few dead links in docs, small changes to make 1st time dev instructions bit more clear #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstelter-slac
changed the title
Doc update
DOC: fix a few dead links in docs, link from readme to contributing doc so can't miss it, and explicitly list dev instructions
Aug 26, 2024
nstelter-slac
changed the title
DOC: fix a few dead links in docs, link from readme to contributing doc so can't miss it, and explicitly list dev instructions
DOC: fix a few dead links in docs, small changes to make 1st time dev instructions bit more clear
Aug 26, 2024
nstelter-slac
force-pushed
the
doc_update
branch
from
September 24, 2024 17:40
70a3025
to
ac12d66
Compare
ZLLentz
reviewed
Sep 24, 2024
ZLLentz
reviewed
Sep 24, 2024
ZLLentz
previously approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fixes/additions!
tangkong
previously approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too! Thanks for the updates!
nstelter-slac
dismissed stale reviews from tangkong and ZLLentz
via
September 25, 2024 19:08
7ea8fa8
ZLLentz
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve some minor things i noticed while reading the docs for 1st time: fix a few dead links in docs, link from readme to contributing doc so can't miss it, and explicitly list dev instructions
Motivation and Context
How Has This Been Tested?
Where Has This Been Documented?
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page