TST: wait for conditions during troublesome tests #185
Conversation
|
I can expand this treatment to other tests, but I also haven't managed to see a test suite failure throughout the course of this PR. If anyone has a better stress test methodology I'd love to try it |
tangkong
changed the title
|
One way to stress test this is to use pytest-repeat but that might reveal other test suite issues |
lightpath/tests/test_widgets.py
Outdated
| in ipimb_row.state_label.styleSheet()) | ||
|
|
||
| wait_until(half_removed) | ||
| assert half_removed |
There was a problem hiding this comment.
I think these are all typos, you meant to assert the function result, right?
| assert half_removed | |
| assert half_removed() |
There was a problem hiding this comment.
hah no wonder it never failed 🤦
There was a problem hiding this comment.
Interestingly, locally the removed case can seemingly hang forever (10+ seconds, which is effectively forever for a computer brain)
Will investigate further
| lightapp.destination_combo.setCurrentIndex(4) # set current to MEC | ||
| # Create mock functions | ||
| for row in lightapp.rows: | ||
| monkeypatch.setattr(row[0], 'setHidden', Mock()) | ||
| # Initialize properly with nothing hidden | ||
| lightapp.filter() | ||
| for row in lightapp.rows: | ||
| row[0].setHidden.assert_called_with(False) | ||
| qtbot.waitUntil(lambda: row[0].setHidden.assert_called_with(False)) |
There was a problem hiding this comment.
How do these statements work? The encapsuled assert_called_with is actually an assert statement. Does it have some undocumented return value?
https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_called_with
There was a problem hiding this comment.
Nevermind, I didn't know qtbot would wait until the assertion passed
There was a problem hiding this comment.
Yea this is some fanciness I picked up while filling out the atef test suite.
Description
Try to fix tests in #169. Changes like these could be spread in many places
Basically just assert things with a timeout to give conditions the ability to settle.
Motivation and Context
#169 , and other tests
How Has This Been Tested?
Locally, and by hitting the GHA re-run button a bunch of times, likely
Where Has This Been Documented?
This PR.