DEV: Modify pytest kwargs #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2018 09:29
Logs are dumped to file at DEBUG level by #49
Show conflicts with newer command line arguments added to pytest. Leading to an error message complaining about ambiguous options.
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 5 5
Lines 391 391
=======================================
Hits 374 374
Misses 17 17Continue to review full report at Codecov.
|
hhslepicka
approved these changes
Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated my version of
pytestand ran into this issue pytest-dev/pytest#3413.The TL;DR is a combination of the argument parsing in
pytestand the defaultargparselibrary does not like when one command line argument is just a shortened version of another. Inpytest=3.5it appears they added arguments that start withshowso when ever I tried to use my argument I receivedI have renamed
showtoshow-uiand now there are no conflicts! Also, after #49 there is no need to have command line arguments to configure the logging setup. These have been deprecated.