Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change JavaVersion to 17 #9

Closed
wants to merge 1 commit into from
Closed

chore: change JavaVersion to 17 #9

wants to merge 1 commit into from

Conversation

ondrejnedoma
Copy link

On RN 0.73 and Expo 50, this package refuses to compile with an error message, unless this change is made. This project really has no reason to require JDK 11 anymore, as JDK 17 is recommended by RN docs.

@ondrejnedoma
Copy link
Author

ondrejnedoma commented Jan 15, 2024

More details on this error:

When a RN 0.73, Expo 50 app tries to run with JDK 11:
Android Gradle plugin requires Java 17 to run. You are currently using Java 11.

When an app that also includes expo-material3-theme CURRENTLY gets ran with JDK 17:
Execution failed for task ':pchmn-expo-material3-theme:compileDebugKotlin'. 'compileDebugJavaWithJavac' task (current target is 17) and 'compileDebugKotlin' task (current target is 11) jvm target compatibility should be set to the same Java version.

This commit makes it so that with JDK 17, the app runs successfully

@pchmn
Copy link
Owner

pchmn commented Jan 15, 2024

Thanks for the PR !
But your changes make use of JDK 17 mandatory, even for previous expo sdk version (<50).

@pchmn
Copy link
Owner

pchmn commented Jan 15, 2024

@ondrejnedoma I just published v1.3.2 which should work with expo sdk v50 as well as previous versions.
Let me know if it works for you

@ondrejnedoma
Copy link
Author

Does work, closing the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants