New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timing oracle that is likely exploitable to forge MACs #11

Closed

jbtule opened this issue May 22, 2013 · 0 comments

Assignees

jbtule commented May 22, 2013

            if (!mac.Equals(attributes["mac"]))
            {
                throw new SecurityException("Bad mac");
            }

This is a well known implementation mistake. You should use a constant time comparison.

ghost assigned pcibraro

pcibraro pushed a commit that referenced this issue


          Fixed issue #11

87ec0d7

pcibraro closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment