Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

junit scope should be "test" in pom.xml #67

Open
pgrt opened this issue Feb 26, 2022 · 0 comments
Open

junit scope should be "test" in pom.xml #67

pgrt opened this issue Feb 26, 2022 · 0 comments

Comments

@pgrt
Copy link

pgrt commented Feb 26, 2022

Hi,

The impact is low, but I suggest adding
<scope>test</scope>
to the 4 junit-* artifacts that are in pom.xml, as they are truly only needed for the tests; of course this is relevant only if the testCases folder is moved under src/test/java/org/snpsift, which you maybe do not want.

Best wishes,

Pierre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant