Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2FA support #79

Open
gdzevo opened this issue Oct 19, 2018 · 26 comments
Open

Add 2FA support #79

gdzevo opened this issue Oct 19, 2018 · 26 comments

Comments

@gdzevo
Copy link

gdzevo commented Oct 19, 2018

Is there any chance to get 2FA support or at least update related documentation on https://docs.pcloud.com/
I made a choice to use pcloud because you had clients for most of systems, even for those that do not have GUI installed.

@blackjackshellac
Copy link

I also cannot use this client because of the lack of 2FA.

@FatmanUK
Copy link

If I'm reading the debug log correctly, having 2FA enabled on the pCloud account and trying to use this client gives the error "NOTICE: pdiff.c:241 (function get_connected_socket): userinfo returned error 1141 Please provide 'deviceid'.", which sorta makes sense if 2FA is half-implemented already.

I found a "devices" table in the .pcloud/data.db SQLite database, but I don't know if that's related, and I can't be bothered to look any further. I'm going to do something more fun. :)

@matthewadie
Copy link

I would love to see this too... I would prefer to keep my cloud storage in sync with a local headless server of my own but I'm unwilling to abandon 2 factor to do so.

@mmguero
Copy link

mmguero commented Feb 18, 2019

This is also a major concern for me. Support for 2FA for the command line client would be great.

@tsubus
Copy link

tsubus commented Mar 22, 2019

+1

@gdzevo
Copy link
Author

gdzevo commented May 1, 2019

Added experimental PR with TFA support - #94
Reviewers and testers are welcome.

@hansvb
Copy link

hansvb commented Nov 23, 2019

+1

@sege
Copy link

sege commented Dec 3, 2019

+1 not able to use it with 2fa support..

@m-alt-f
Copy link

m-alt-f commented Feb 15, 2020

+1, I am not able to use it with 2fa and would love to be able to.

@AlexKlimaj
Copy link

+1

@dwcaesar
Copy link

+1

5 similar comments
@fermen01
Copy link

+1

@troyvassalotti
Copy link

+1

@paudebau
Copy link

+1

@DjSni
Copy link

DjSni commented Feb 19, 2022

+1

@swirlypillow
Copy link

+1

@dberlin
Copy link

dberlin commented Apr 18, 2022

#163 should fix this for you, assuming you are just using an authenticator and not SMS

@m-alt-f
Copy link

m-alt-f commented Apr 19, 2022

This looks good! Is there a way for me to test this before it's been merged with main?

#163 should fix this for you, assuming you are just using an authenticator and not SMS

@dberlin
Copy link

dberlin commented Apr 19, 2022

Starting from scratch, something like this should work (If you already have a checkout of console client, you can start from the fetch command)
❯ git clone https://github.com/pcloudcom/console-client.git
❯ cd console-client
❯ git fetch origin pull/163/head:tfa-support
❯ git checkout tfa-support

Then just build it following the normal build instructions.
when you start pcloudcc, add -t <2fa code> to the command line.
I haven't added support for prompting for the 2fa code, but it would not be hard if someone wants to do it (the change is very simple to follow. Where it calls psync_set_tfa_code, you can make it prompt the user for the code instead of reading it from the command line option)
It will also auto-mark the computer you do this on as trusted (which should also be an option), so you won't get 2fa prompted for like 30 days i believe.

@dberlin
Copy link

dberlin commented Apr 19, 2022

So i took a few minutes and added (untested) support for prompting for the 2fa code if you don't set it on the command line.
I also made whether to trust the device an option.
Feel free to try it out and let me know if it works.

@swirlypillow
Copy link

Awesome, thanks! This going to get merged to master?

@DennisNikolay
Copy link

So i took a few minutes and added (untested) support for prompting for the 2fa code if you don't set it on the command line. I also made whether to trust the device an option. Feel free to try it out and let me know if it works.

Works great, thanks! Is the console client maintained at all because I feel like this should get more attention.

@tyjak
Copy link

tyjak commented May 23, 2023

Any chance to have 2fa support anytime without to checkout an experimental branch #163 ???

@decorte
Copy link

decorte commented Jan 23, 2024

no tfa support is making this app unusable! please do something about it.... #163 is not working for me

@gdzevo
Copy link
Author

gdzevo commented Jan 24, 2024

@decorte you could try rclone with mount command.`

Based on my observations pCloud team is mostly focused on sales and not support. That applies no only to this abandoned linux client but even to the mac application.
I regret that bought life-time plan, to be honest.

@le-avion
Copy link

le-avion commented May 7, 2024

I built this following the instructions above and the original build instructions.
When I try to login with the following command line

pcloudcc -u email@domain.com -t 123456 -p

I am still getting the following error:

pCloud console client v.2.0.1
Please, enter password
Down: Everything Downloaded| Up: Remaining: 1 files, 0Bytes, status is CONNECTING
Down: Everything Downloaded| Up: Remaining: 1 files, 0Bytes, status is BAD_LOGIN_TOKEN

Does this work for anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests