Skip to content

Commit

Permalink
Fix tests and add TODOs to tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jnothman committed Apr 8, 2017
1 parent 7c54a69 commit 9a62699
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion pandas/tests/formats/test_css.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_css_parse_comments():
markers like !important, but we should
ignore them in the future''')
def test_css_parse_specificity():
pass
pass # TODO


@pytest.mark.xfail
Expand Down
16 changes: 10 additions & 6 deletions pandas/tests/formats/test_to_excel.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@
'patternType': 'solid'}}),
# BORDER
# - style
# TODO: need to check this produces valid OpenXML without color
('border-style: solid',
{'border': {'top': {'style': 'medium'},
'bottom': {'style': 'medium'},
Expand All @@ -96,11 +95,16 @@
{'border': {'top': {'style': 'mediumDashDotDot'}}}),
('border-top-style: dashed',
{'border': {'top': {'style': 'mediumDashed'}}}),
# TODO: test other widths
# - color
# TODO
# ALIGNMENT
# - horizontal
# TODO
# - vertical
# TODO
# - wrap_text
# TODO
])
def test_css_to_excel(css, expected):
convert = CSSToExcelConverter()
Expand All @@ -117,10 +121,10 @@ def test_css_to_excel_multiple():
unused: something;
''')
assert {"font": {"bold": True},
"border": {"top": {"style": "hair"},
"right": {"style": "hair"},
"bottom": {"style": "hair"},
"left": {"style": "hair"}},
"border": {"top": {"style": "thin"},
"right": {"style": "thin"},
"bottom": {"style": "thin"},
"left": {"style": "thin"}},
"alignment": {"horizontal": "center",
"vertical": "top"}} == actual

Expand All @@ -145,4 +149,4 @@ def test_css_to_excel_inherited(css, inherited, expected):

@pytest.mark.xfail
def test_css_to_excel_warns_when_not_supported():
pass
pass # TODO

0 comments on commit 9a62699

Please sign in to comment.