Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing inline decls #31

Merged
merged 1 commit into from
Jul 4, 2016
Merged

Missing inline decls #31

merged 1 commit into from
Jul 4, 2016

Conversation

bchoi
Copy link

@bchoi bchoi commented Jun 28, 2016

  • fully-specialized templated functions
  • implemented functions in header files

- fully-specialized templated functions

- implemented functions in header files
@coveralls
Copy link

coveralls commented Jun 28, 2016

Coverage Status

Coverage remained the same at 80.934% when pulling 1ad276f on bchoi:master into 7d7fca9 on pcolby:master.

@codecov-io
Copy link

Current coverage is 80.93%

Merging #31 into master will not change coverage

@@             master        #31   diff @@
==========================================
  Files             9          9          
  Lines           771        771          
  Methods           5          5          
  Messages          0          0          
  Branches        428        428          
==========================================
  Hits            624        624          
  Misses          147        147          
  Partials          0          0          

Powered by Codecov. Last updated by 7d7fca9...1ad276f

@pcolby pcolby merged commit 4d18a1b into pcolby:master Jul 4, 2016
@pcolby
Copy link
Owner

pcolby commented Jul 4, 2016

Thanks @bchoi! 👍

I had to go a read up on fully-specialized template functions! 😄

@bchoi
Copy link
Author

bchoi commented Jul 5, 2016

@pcolby Not a problem. Thank you for this awesome library!

@pcolby
Copy link
Owner

pcolby commented Jul 14, 2016

Hey @bchoi,

Just FYI, the email address you used to make these changes (byn dot choi at sap dot com) is not recognised by Github as belonging to you. This isn't a problem, but does mean that you get less credit from Github recognising those changes as yours.

Its not necessary, but I'd recommend you go into your Github Email settings, and add that address as an additional address for your account. Then, for example, Github should list you as one of the contributors at https://github.com/pcolby/pcp-pmda-cpp/graphs/contributors 😄

Cheers.

@bchoi
Copy link
Author

bchoi commented Jul 22, 2016

Paul-

Thanks for letting me know! I've added my work address there now so
hopefully that'll resolve github's confusion :)

Thanks again for the great library, I love how clean and intuitive the
interface is.

Byn

On Wed, Jul 13, 2016 at 8:46 PM, Paul Colby notifications@github.com
wrote:

Hey @bchoi https://github.com/bchoi,

Just FYI, the email address you used to make these changes (byn dot choi
at sap dot com) is not recognised by Github as belonging to you. This isn't
a problem, but does mean that you get less credit from Github recognising
those changes as yours.

Its not necessary, but I'd recommend you go into your Github Email
settings https://github.com/settings/emails, and add that address as an
additional address for your account. Then, for example, Github should list
you as one of the contributors at
https://github.com/pcolby/pcp-pmda-cpp/graphs/contributors 😄

Cheers.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#31 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAW9j3wA_Lcg4vThQHD6OQRi-CF_hVkfks5qVbEvgaJpZM4I_nwd
.

@pcolby
Copy link
Owner

pcolby commented Jul 22, 2016

👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants