-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing inline decls #31
Conversation
bchoi
commented
Jun 28, 2016
- fully-specialized templated functions
- implemented functions in header files
- fully-specialized templated functions - implemented functions in header files
Current coverage is 80.93%@@ master #31 diff @@
==========================================
Files 9 9
Lines 771 771
Methods 5 5
Messages 0 0
Branches 428 428
==========================================
Hits 624 624
Misses 147 147
Partials 0 0
|
Thanks @bchoi! 👍 I had to go a read up on fully-specialized template functions! 😄 |
@pcolby Not a problem. Thank you for this awesome library! |
Hey @bchoi, Just FYI, the email address you used to make these changes (byn dot choi at sap dot com) is not recognised by Github as belonging to you. This isn't a problem, but does mean that you get less credit from Github recognising those changes as yours. Its not necessary, but I'd recommend you go into your Github Email settings, and add that address as an additional address for your account. Then, for example, Github should list you as one of the contributors at https://github.com/pcolby/pcp-pmda-cpp/graphs/contributors 😄 Cheers. |
Paul- Thanks for letting me know! I've added my work address there now so Thanks again for the great library, I love how clean and intuitive the Byn On Wed, Jul 13, 2016 at 8:46 PM, Paul Colby notifications@github.com
|
👍 😄 |