Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICEpdf asks the user to save the pdf on exit even if no modification has been done since the last save #25

Closed
gtache opened this issue Feb 6, 2020 · 0 comments · Fixed by #183
Closed

ICEpdf asks the user to save the pdf on exit even if no modification has been done since the last save #25

gtache opened this issue Feb 6, 2020 · 0 comments · Fixed by #183
Labels
bug Something isn't working Core Core rendering mdodule Viewer Viewer Module

Comments

@gtache
Copy link
Contributor

gtache commented Feb 6, 2020

I think the user shouldn't be asked if they want to save the pdf if it hasn't changed since the last save.
gtache added a commit to gtache/icepdf that referenced this issue Feb 6, 2020
@gtache
pcorlessGH-25 Don't ask the user to save if no changes have been made…
5cbdc22 
… since last save
@gtache gtache mentioned this issue Feb 6, 2020
Closed
@pcorless pcorless added bug Something isn't working Core Core rendering mdodule Viewer Viewer Module labels Feb 12, 2020
@pcorless pcorless added this to the 6.4.0 milestone Feb 12, 2020
gtache added a commit to gtache/icepdf that referenced this issue Feb 12, 2020
@gtache
pcorlessGH-25 Fixes conflicts
766d16a
pcorless pushed a commit that referenced this issue May 3, 2020
GH-25 fix issue where Annotation that are added for rendering purpose…
cceae2a 
…s cause the save as dialog ot appear on close, even know the users make no changes the document.
gtache added a commit to gtache/icepdf that referenced this issue May 11, 2020
@gtache
pcorlessGH-25 Takes updated pobjects into account
d26ae25
gtache added a commit to gtache/icepdf that referenced this issue Mar 18, 2021
@gtache
pcorlessGH-25 Adds getChangesSince
db74389
pcorless pushed a commit that referenced this issue Apr 3, 2021
Merge branch 'master' into GH-25.fix.modified.statemanager.on.missing…
36293c4 
….content.stream

# Conflicts:
#	core/core-awt/src/main/java/org/icepdf/core/pobjects/StateManager.java
#	logging.properties
#	viewer/viewer-awt/src/main/java/org/icepdf/ri/common/tools/TextAnnotationHandler.java
#	viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/AbstractAnnotationComponent.java
#	viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/MarkupAnnotationComponent.java
pcorless pushed a commit that referenced this issue Apr 13, 2021
GH-25 fix issue where Annotation that are added for rendering purpose…
433042f 
…s cause the save as dialog ot appear on close, even know the users make no changes the document.
pcorless pushed a commit that referenced this issue Apr 13, 2021
GH-25 further refinement of state management related to user changes …
4a0647b 
…vs. rendering changes.
pcorless added a commit that referenced this issue Apr 13, 2021
@pcorless
GH-25 only ask to save document if changes were user initiated. (#183)
919f2b2
@pcorless pcorless linked a pull request Apr 13, 2021 that will close this issue
GH-25 only ask to save document if changes were user initiated. #183
Merged
pcorless pushed a commit that referenced this issue Apr 13, 2021
GH-25 fix class cast error when trying to save the new Change state, …
9020fda 
…darn it.
pcorless pushed a commit that referenced this issue Oct 21, 2021
GH-25 fix getChange regression causing al sort of trouble with annota…
541dd58 
…tion creation and writes.
pcorless added a commit that referenced this issue Feb 1, 2022
@gtache @pcorless
GH-42 Simple save function (#43)
f97b85b 
* GH-25 Don't ask the user to save if no changes have been made since last save

* GH-42 Implements save with same name on Ctrl+S

* Adds timer at document open to get initial changes

* Reverts pom.xml

* Fixes conflict with PropertiesManager renaming

* GH-42 Fixes error on close if document is null

* Reformats MessageBundles

* GH-25 Takes updated pobjects into account

* GH-42 Disable save menu item when document is closed

* GH-42 Fixes saveAs not saving changes

* GH-42 Simplify isChange

* GH-42 Uses Map instead of HashMap

* GH-42 Adds getter for isNew

* GH-42 Fixes library getting the Change instance instead of the Object

* GH-42 Fixes the temp save filename not working if the filename contains a '.'

Co-authored-by: Patrick Corless <pcorless@users.noreply.github.com>
gtache pushed a commit to gtache/icepdf that referenced this issue Sep 6, 2023
pcorlessGH-25 Pass isNew to stateManager in various methods
f385281
pcorless pushed a commit that referenced this issue Jan 24, 2024
@gtache
GH-25 Pass isNew to stateManager in various methods (#296)
123a704 
Co-authored-by: Guillaume Tâche <tga@bger.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Core Core rendering mdodule Viewer Viewer Module
Projects
None yet
Milestone
No milestone
2 participants
@pcorless @gtache