Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make modal draggable #1146

Merged
merged 1 commit into from
May 13, 2024
Merged

make modal draggable #1146

merged 1 commit into from
May 13, 2024

Conversation

hiroto1220
Copy link
Contributor

This chage allows you to move the modal that comes up when doing an interactive rebase.
I think this is useful when you want to work on a modal while looking at the goal. (ex. level2 move2)

  • before
    スクリーンショット 2024-05-13 22 08 53

  • after
    スクリーンショット 2024-05-13 22 09 39

Copy link

netlify bot commented May 13, 2024

Deploy Preview for xenodochial-hugle-b9ec84 ready!

Name Link
🔨 Latest commit e5cab6a
🔍 Latest deploy log https://app.netlify.com/sites/xenodochial-hugle-b9ec84/deploys/66421220c5b5e70007c59dc2
😎 Deploy Preview https://deploy-preview-1146--xenodochial-hugle-b9ec84.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pcottle
Copy link
Owner

pcottle commented May 13, 2024

Awesome contribution! But I think this makes all terminal windows draggable, including the window for selecting a level and a bunch others.

Could we just do this change on ./js/views/rebaseView.js so its contained to just the interactive rebase one?

@hiroto1220
Copy link
Contributor Author

Thanks for the review!
I think it would be fine if all terminal windows are draggable, such as to see Instractions while checking the current conditions.

@pcottle pcottle merged commit 81d9bdf into pcottle:main May 13, 2024
5 checks passed
@pcottle
Copy link
Owner

pcottle commented May 13, 2024

Hrm I wasn't able to get it to drag all the way down -- could you?
Screenshot 2024-05-13 at 7 37 40 PM

the goal window successfully can drag all the way down

@hiroto1220
Copy link
Contributor Author

I wasn't able to do it.
I can do it in the local environment, but not after deployment.😕

@pcottle
Copy link
Owner

pcottle commented May 14, 2024

Yeah the draggable jQuery plugin is quite old and I wouldn't be surprised if it's buggy. I might revert this change just so we avoid any bugs but appreciate the PR anyways!

pcottle pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants