-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vidscraper to work with requests >= 1.0 #18
Conversation
The test requirements file needs to be updated. The travis run is failing because it's still installing requests < 1.0. |
What version do you want to peg it to? |
Latest is fine with me. 1.2.3? |
Maybe also remove the commented-out line from setup.py, as long as you're doing another commit anyway? |
^^^ Nixed the commented out line and updated test_requirements.txt. |
I'm also concerned that there might be some issues with OAuth handling. I seem to remember that being an issue last time I looked into doing this transition... and the OAuth sections aren't currently covered by the tests. :-p Did you happen to look into that? If not, I'd probably be fine with merging this as-is anyway, and just fixing those issues when they come up. |
I didn't look into that and don't use the Vimeo support, so it's not something I'm set up to look into very well. |
Kk, no worries. Looks good. |
Fix vidscraper to work with requests >= 1.0
Thank you! |
FTR: bz19777 |
This fixes all the json -> json() calls. Everything in the test suite passes, so I think it's good to go.