Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vidscraper to work with requests >= 1.0 #18

Merged
merged 2 commits into from
May 31, 2013
Merged

Fix vidscraper to work with requests >= 1.0 #18

merged 2 commits into from
May 31, 2013

Conversation

willkg
Copy link
Contributor

@willkg willkg commented May 31, 2013

This fixes all the json -> json() calls. Everything in the test suite passes, so I think it's good to go.

@melinath
Copy link
Contributor

The test requirements file needs to be updated. The travis run is failing because it's still installing requests < 1.0.

@willkg
Copy link
Contributor Author

willkg commented May 31, 2013

What version do you want to peg it to?

@melinath
Copy link
Contributor

Latest is fine with me. 1.2.3?

@melinath
Copy link
Contributor

Maybe also remove the commented-out line from setup.py, as long as you're doing another commit anyway?

@willkg
Copy link
Contributor Author

willkg commented May 31, 2013

^^^ Nixed the commented out line and updated test_requirements.txt.

@melinath
Copy link
Contributor

I'm also concerned that there might be some issues with OAuth handling. I seem to remember that being an issue last time I looked into doing this transition... and the OAuth sections aren't currently covered by the tests. :-p Did you happen to look into that? If not, I'd probably be fine with merging this as-is anyway, and just fixing those issues when they come up.

@willkg
Copy link
Contributor Author

willkg commented May 31, 2013

I didn't look into that and don't use the Vimeo support, so it's not something I'm set up to look into very well.

@melinath
Copy link
Contributor

Kk, no worries. Looks good.

melinath added a commit that referenced this pull request May 31, 2013
Fix vidscraper to work with requests >= 1.0
@melinath melinath merged commit 19c245a into pculture:develop May 31, 2013
@willkg
Copy link
Contributor Author

willkg commented May 31, 2013

Thank you!

@melinath
Copy link
Contributor

FTR: bz19777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants