Add vidscraper-cmd. #7
Conversation
|
| # fetchvideo -> auto_scrape(url, fields, api_keys) | ||
|
|
||
|
|
||
| class CommandHandler(object): |
There was a problem hiding this comment.
For clarity, perhaps VidscraperCommandHandler?
|
Comments aside, I'm excited that other people find Vidscraper useful; thanks for the request! |
|
Cool. Sounds like the general structure is good. I'll fix up the issues you mentioned and clean some other things up (and include the topic file I wrote but forgot to add to the commit). |
|
Yes, the structure looks good. I like that you've made it easy to extend with new commands in the future. |
|
Looks good. Only thing that's bothering me atm is the use of |
|
Rebased from master so it should apply cleanly now. Addressed other issues from your comments. |
|
The branch needs to be rebased onto develop, not master, unfortunately. :-) |
|
Whoops. This project is different than all the other ones I work on and I forgot. |
|
Rebased against develop and re-pushed. |
|
Are you sure it's rebased against our develop? Github says it still can't be merged, and the list of commits (https://github.com/pculture/vidscraper/pull/7/commits) includes a bunch that have already happened. |
|
|
||
| class VideoTestCase(unittest.TestCase): | ||
| def test_items(self): | ||
| video = auto_scrape("http://www.youtube.com/watch?v=J_DV9b0x7v4") |
There was a problem hiding this comment.
Yay tests! Doing it this way, though, requires that Vidscraper actually go to YouTube and grab some data, and you aren't actually looking at the data. Can you test this by just making a plain Video instance?
There was a problem hiding this comment.
Show me an example of how to do that with your system and I'll change the code.
I'm really running out of time I can spend on the nit-picky stuff.
There was a problem hiding this comment.
vidscraper.videos.Video(url) won't actually load the URL.
This adds the beginnings of a vidscraper-cmd. It supports auto-scraping
videos, but nothing else, yet. However, the code is written such that
adding support for other actions is easy to do.
The video subcommand supports specifying fields to be returned and also
api keys (though the latter is untested).
It returns data in JSON format--which required adding ``items()`` and
``to_json()`` methods to the Video class.
Also adds a new topic in the documentation.
Closes #6.
* adds missing files * improves documentation * adds tests for new Video methods * handles datetime.datetime serialization issues with json.dumps.
|
That should fix the rebasing issue. I'm kind of out of time I can spend on upstreaming this. So if it's not good as is, I'll just maintain my fork with this and future things I want to do. Then you can cherry-pick whatever is interesting to you. |
|
Still not mergeable, but I've rebased it and filed #8 with the changes. |
This adds the beginnings of a vidscraper-cmd. It supports auto-scraping
videos, but nothing else, yet. However, the code is written such that
adding support for other actions is easy to do.
The video subcommand supports specifying fields to be returned and also
api keys (though the latter is untested).
It returns data in JSON format--which required adding
items()andto_json()methods to the Video class.Also adds a new topic in the documentation.
Closes #6.