Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to modern PyTorch #15

Merged
merged 8 commits into from
Sep 23, 2019
Merged

Upgrade to modern PyTorch #15

merged 8 commits into from
Sep 23, 2019

Conversation

neubig
Copy link
Collaborator

@neubig neubig commented Aug 3, 2019

This is a first draft of an upgrade that doesn't specify version numbers in the conda file, allowing users to use the most recent version of the libraries. Changes in PyTorch broke some things, but I think I fixed them.

This should help address this: #10, and should be checked after this: #12

@neubig
Copy link
Collaborator Author

neubig commented Aug 7, 2019

I think this should basically be complete (including upgrade of the environment, and conversion of all deprecated PyTorch functions). I've confirmed that the accuracy seems to be fine on geoquery, getting 89.6 for a single run, which is higher than the TranX paper:

{'accuracy': 0.8964285714285715, 'oracle_accuracy': 0.9214285714285714}

I'm running CoNaLa now and will report, but I think this is ready for a check if you have time @pcyin

@neubig neubig mentioned this pull request Aug 7, 2019
@neubig
Copy link
Collaborator Author

neubig commented Aug 7, 2019

It seems to also be working on CoNaLa as well, where accuracy is within error of the reported results in the ACL 2019 paper (https://www.aclweb.org/anthology/P19-1447):

{'corpus_bleu': 0.24097779142849596, 'oracle_corpus_bleu': 0.3697198327631323, 'avg_sent_bleu': 0.20894283286460824, 'oracle_avg_sent_bleu': 0.34892593973337316, 'exact_      match': 0.02, 'oracle_exact_match': 0.052}

@pcyin pcyin merged commit b604f19 into pcyin:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants