Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for color type option in generator #436

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Added support for color type option in generator #436

merged 3 commits into from
Mar 4, 2024

Conversation

necessarylion
Copy link
Contributor

@necessarylion necessarylion commented Feb 29, 2024 •
edited
Loading 

const pdf = await generate({
    ...
    options: {
      ...
      font, 
      // now support CMYK or RGB color type
      // if the value is not set, hex color will be generated into RGB color type
      colorType: 'cmyk'
    },
});

Color type will applied to text, line, rect and ellipse which are the the components that need colors at the moment.

@vercel Vercel
Copy link

vercel bot commented Feb 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
pdfme-playground ⬜️ Ignored (Inspect) Visit Preview Mar 3, 2024 10:18am
pdfme-playground-v4 ⬜️ Ignored (Inspect) Visit Preview Mar 3, 2024 10:18am

@hand-dot
Copy link
Collaborator

hand-dot commented Mar 1, 2024

Hey @necessarylion !!!
So cool!

This weekend I will check this.

hand-dot
hand-dot requested changes Mar 3, 2024
View reviewed changes
Copy link
Collaborator

@hand-dot hand-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great work. Please fix the part where var is used, as we would prefer not to use it.

packages/schemas/src/utils.ts Outdated Show resolved Hide resolved
hand-dot
hand-dot approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@hand-dot hand-dot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hand-dot hand-dot mentioned this pull request Mar 4, 2024
Closed
@hand-dot hand-dot merged commit 18cf33d into pdfme:main Mar 4, 2024
2 of 3 checks passed
@hand-dot
Copy link
Collaborator

hand-dot commented Mar 4, 2024

@necessarylion

Released! https://github.com/pdfme/pdfme/releases/tag/3.3.0

Thank you for your contribution 👍

@nicorsm nicorsm mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hand-dot hand-dot hand-dot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@necessarylion @hand-dot