Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an API for custom tabs and panels in left panel #29

Closed
ZhijieZhang opened this issue Oct 30, 2018 · 2 comments
Closed

Create an API for custom tabs and panels in left panel #29

ZhijieZhang opened this issue Oct 30, 2018 · 2 comments
Assignees
@ZhijieZhang
Labels
enhancement New feature or request

Comments

@ZhijieZhang
Copy link
Contributor

No description provided.

@ZhijieZhang ZhijieZhang self-assigned this Oct 30, 2018
@ZhijieZhang ZhijieZhang added the enhancement New feature or request label Oct 30, 2018
ZhijieZhang added a commit that referenced this issue Oct 30, 2018
@ZhijieZhang
[new] resolves #29
466ff1f
@sabieber
Copy link
Contributor

sabieber commented Nov 7, 2018

The new API is really nice 👍
Only thing i noticed with it is that it does not add the normal Panel class the normal panes have to the created DOM element. Could this be improved when rendering the custom panel?

@ZhijieZhang
Copy link
Contributor Author

Hi there! What you are suggesting definitely makes sense, we will add it soon. Thanks for you reply

@ZhijieZhang ZhijieZhang reopened this Nov 7, 2018
ZhijieZhang added a commit that referenced this issue Nov 7, 2018
@ZhijieZhang
[update] resolves #29. Add class 'Panel' to custom panels, also make …
11b9d82 
…sure that custom panel have flex-grow 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZhijieZhang ZhijieZhang

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sabieber @ZhijieZhang