-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: package-type fixer
to avoid duplicated empty section
#2578
Conversation
package-type fixer
to avoid duplicated empty section
thanks for the fix. I will review it tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though a bit ugly, modifying a TOML while keeping the styles and orders are hard.
Opps, sorry for my silly typo |
I will test it locally and maybe put the lock file in the test project. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2578 +/- ##
==========================================
+ Coverage 84.76% 84.79% +0.02%
==========================================
Files 104 104
Lines 10387 10387
Branches 2272 2272
==========================================
+ Hits 8805 8808 +3
+ Misses 1106 1105 -1
+ Partials 476 474 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
close: #2577
Pull Request Checklist
news/
describing what is new.Describe what you have changed in this PR.
This seems to be a tomlkit issue, the workaround(instead of fixing upstream) here is to pop the parent section and write back the whole.