Display link text correctly #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernc
reviewed
May 24, 2020
ButterflyBug
force-pushed
the
link_text_issue_201
branch
from
3b95dd2
to
25758bf
Compare
|
Hi, I've just updated my PR 😃 Let me know if you make up some another suspicious type of URLs 😄 |
kernc
reviewed
Jun 1, 2020
ButterflyBug
force-pushed
the
link_text_issue_201
branch
from
25758bf
to
d364987
Compare
kernc
reviewed
Jun 7, 2020
ButterflyBug
force-pushed
the
link_text_issue_201
branch
2 times, most recently
from
466aba8
to
6be0409
Compare
kernc
requested changes
Jun 16, 2020
ButterflyBug
force-pushed
the
link_text_issue_201
branch
from
6be0409
to
07eef82
Compare
In generated documentation the link text placed into [] is not followed by left angle brakcet and it redirects to the given website. Moreover, improved regular expression enables displaying url given in parentheses or url containing them, i.e.: (https://example.com) https://example.com/more_(examples)
ButterflyBug
force-pushed
the
link_text_issue_201
branch
from
07eef82
to
434e068
Compare
kernc
approved these changes
Jun 26, 2020
|
I pushed some pedantic touch-ups I didn't feel like voicing aloud. This now looks good and should hopefully stick as far as wrapping raw URLs goes. 🤞 Much appreciated! If you care to make other regexes in the module more reader-friendly, or if you find other bugs, obviously welcome. 😁 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In generated documentation, the link text placed into [] is not followed
by left angle bracket and it redirects to the given website.
Closes #201