Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle chores #205

Merged
merged 6 commits into from
May 3, 2024
Merged

Gradle chores #205

merged 6 commits into from
May 3, 2024

Conversation

sschuberth
Copy link
Contributor

Please have a look at the individual commit messages for the details.

@pdvrieze
Copy link
Owner

pdvrieze commented May 2, 2024

Please base the pull request on dev (which contains the current work)

The development happens mainly on the dev branch (which has newer versions), but also has the start of attempting splitting out Android/Jvm targets into separate submodules (rather than 2 variants in multiplatform - this is deprecated in kotlin multiplatform).

@sschuberth sschuberth changed the base branch from master to dev May 2, 2024 10:16
@sschuberth
Copy link
Contributor Author

Please base the pull request on dev (which contains the current work)

Done @pdvrieze.

Copy link
Owner

@pdvrieze pdvrieze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some versions needed to be deleted. But otherwise should be merge. Thanks for the work

@sschuberth
Copy link
Contributor Author

Some versions needed to be deleted. But otherwise should be merge. Thanks for the work

Let me rebase once more to resolve conflicts.

@pdvrieze pdvrieze merged commit 5373c40 into pdvrieze:dev May 3, 2024
4 checks passed
@pdvrieze
Copy link
Owner

pdvrieze commented May 3, 2024

Thanks for the work. Now merged (with some small changes)

@sschuberth
Copy link
Contributor Author

Thanks for the work. Now merged (with some small changes)

You missed one spot 😉 #207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants