Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get new CSS stylesheets #31

Closed
ddeseta opened this issue Jun 7, 2013 · 12 comments
Closed

Get new CSS stylesheets #31

ddeseta opened this issue Jun 7, 2013 · 12 comments

Comments

@ddeseta
Copy link

ddeseta commented Jun 7, 2013

Original Title: Global Navigation for PCV, PCMO, Admin User types

We are missing global navigation for the web browser experience.

Edit: this is functionally complete, but needs to be styled once we have a design.
@ghost ghost assigned ddeseta and pstoica Jun 7, 2013
@ddeseta
Copy link
Author

ddeseta commented Jun 9, 2013

Global navigation has been determined for both PCV and PCMO. Go to this simulation to see them http://share.axure.com/5DCVKG

@ddeseta ddeseta closed this as completed Jun 9, 2013
@jamesdabbs
Copy link
Member

Reopened. Thanks for the design docs, but we still need to implement them. :)

@jamesdabbs jamesdabbs reopened this Jun 9, 2013
@v3n v3n mentioned this issue Jun 9, 2013
Closed
@ddeseta
Copy link
Author

ddeseta commented Jun 9, 2013

OMG can you tell I'm a designer? Thanks for your patience :)

@jasnow jasnow mentioned this issue Jul 16, 2013
Closed
jamesdabbs added a commit that referenced this issue Jul 17, 2013
@jamesdabbs
Add link to new order view. Fixes #61
158c2c3 
Somewhere in the devise swapover we lost the logic that directs
non-admin users to the new order page by default, and there wasn't a
link to it anywhere on the orders list. This adds a "new order" button
visible to non-admin users, and is mostly only intended as a stop-gap
for Patrick to do his user demo. We still need to implement a cohesive
global nav (#31).
@ghost ghost assigned jamesdabbs Jul 17, 2013
jamesdabbs added a commit that referenced this issue Jul 28, 2013
@jamesdabbs
Add global navigation. #31
3ee766c 
The navigation links to things that don't exist yet, but that's a
problem with the non-existent things.

Also, it (clearly) needs some styling.
@jasnow
Copy link
Contributor

jasnow commented Aug 1, 2013

@jamesdabbs - Does your work plus @ddeseta 's simulation answer this issue? Have we finished this issue?

@jamesdabbs
Copy link
Member

Functionally done, but still needs some styling. We're waiting on work from @ddeseta's designer person.

@ghost ghost assigned ddeseta Oct 7, 2013
@jamesdabbs
Copy link
Member

@ddeseta - Where are we on getting the CSS?

@jamesdabbs jamesdabbs mentioned this issue Oct 7, 2013
Closed
@ddeseta
Copy link
Author

ddeseta commented Oct 30, 2013

checking in on the CSS. Haven't heard anything yet.

@jasnow
Copy link
Contributor

jasnow commented Nov 2, 2013

@jamesdabbs added Twitter Bootstrap as a temporary fix.

@ghost ghost assigned jamesdabbs Nov 2, 2013
@jamesdabbs
Copy link
Member

@ddeseta - feel free to check in on the css stuff, but I'm proceeding under the assumption that we're using a (modified) bootstrap base and working towards that unless I hear differently.

By way of reminder to myself. TODO:

  • Style validation errors
  • Style flash messages
  • Swap out logo (8f9877a, though we could use a higher res image)
  • Make request manager rows highlight on hover, have clickable pointer icon (8f9877a)
  • Make sure table striping works with hidden rows (1ced751)
  • Port to Bootstrap 3
  • Clean up vestigial style classes
  • Get an actual designer to look at this

@ghost ghost assigned ddeseta and jamesdabbs Nov 2, 2013
jamesdabbs added a commit that referenced this issue Nov 3, 2013
@jamesdabbs
Some appearance cleanup. #31
8f9877a
jamesdabbs added a commit that referenced this issue Nov 3, 2013
@jamesdabbs
JS compatible table striping #31
1ced751
@ghost ghost assigned ddeseta and emilymerwin Nov 10, 2013
@cpursley
Copy link
Contributor

cpursley commented Dec 2, 2013

Is there still interest in porting this to Bootstrap 3? There are a lot of class / ID changes with 3. I don't mind working on it.

@jasnow
Copy link
Contributor

jasnow commented Dec 2, 2013

They are using Bootstraps 3 - see #217, #219, #234, and #241 and talk to @rgpass.

@choquette33
Copy link
Member

Using Bootstrap 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jasnow @pstoica @jamesdabbs @cpursley @emilymerwin @choquette33 @ddeseta