Implement #279 #280
Merged
Implement #279 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khacminh
requested review from
aykutfarsak and
ilkinulas
and removed request for
a team
ilkinulas
requested changes
Apr 6, 2021
ilkinulas
reviewed
Apr 6, 2021
ilkinulas
reviewed
Apr 9, 2021
ilkinulas
reviewed
Apr 9, 2021
igungor
reviewed
Apr 14, 2021
ilkinulas
reviewed
Apr 15, 2021
ilkinulas
reviewed
Apr 15, 2021
- switch to https://github.com/johannesboyne/gofakes3 - add assertion
sonmezonur
reviewed
Apr 20, 2021
sonmezonur
approved these changes
Apr 21, 2021
ilkinulas
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Issue #279
Issue:
S3 key may contain special characters as mention in this document. In this case, downloading S3 object throws 404 error.
Solution:
The S3 key need to be URL encoded before download.