Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Environment S3_ENDPOINT_URL #343

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Support Environment S3_ENDPOINT_URL #343

merged 3 commits into from
Aug 18, 2021

Conversation

Dexus
Copy link
Contributor

@Dexus Dexus commented Aug 17, 2021 •
edited
Loading

Make the S3_ENDPOINT_URL environment variable usable to omit the --endpoint-url flag.

Closes #326

@Dexus Dexus requested a review from a team as a code owner August 17, 2021 18:01
@Dexus Dexus requested review from ilkinulas and seruman and removed request for a team August 17, 2021 18:01
@ilkinulas
Copy link
Member

Thank you for your contribution.
Could you please update README? There is a section where --endpoint-url is documented. You can add a sample usage there.

@Dexus
Copy link
Contributor Author

Dexus commented Aug 18, 2021

@ilkinulas
I add the example in the README.

@Dexus
Copy link
Contributor Author

Dexus commented Aug 18, 2021

fix the "fmt check"

@ilkinulas ilkinulas merged commit a0791f8 into peak:master Aug 18, 2021
@joshuarobinson
Copy link

Great idea! thanks for this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seruman seruman seruman approved these changes

@ilkinulas ilkinulas ilkinulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make --endpoint-url also usable as ENV
4 participants
@Dexus @ilkinulas @joshuarobinson @seruman