-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command: add content-disposition
flag.
#589
command: add content-disposition
flag.
#589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests please? You may use content type assertions as a reference;
Lines 570 to 574 in af8d725
if opts.contentType != nil { | |
if diff := cmp.Diff(opts.contentType, output.ContentType); diff != "" { | |
return fmt.Errorf("content-type of %v/%v: (-want +got):\n%v", bucket, key, diff) | |
} | |
} |
@denizsurmeli please update the changelog. |
Not related to this PR; #582 introduced flakiness on Windows on |
This PR adds
--content-disposition
flag to thecp
andmv
command, which are used for uploading files.Fixes #569 .