Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command: add content-disposition flag. #589

Merged
merged 13 commits into from
Jul 24, 2023

Conversation

denizsurmeli
Copy link
Contributor

This PR adds --content-disposition flag to the cp and mv command, which are used for uploading files.

Fixes #569 .

@denizsurmeli denizsurmeli requested a review from a team as a code owner July 10, 2023 10:57
@denizsurmeli denizsurmeli requested review from igungor and seruman and removed request for a team July 10, 2023 10:57
Copy link
Member

@seruman seruman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests please? You may use content type assertions as a reference;

s5cmd/e2e/util_test.go

Lines 570 to 574 in af8d725

if opts.contentType != nil {
if diff := cmp.Diff(opts.contentType, output.ContentType); diff != "" {
return fmt.Errorf("content-type of %v/%v: (-want +got):\n%v", bucket, key, diff)
}
}

@denizsurmeli denizsurmeli marked this pull request as draft July 18, 2023 08:40
@denizsurmeli denizsurmeli marked this pull request as ready for review July 18, 2023 08:50
@igungor
Copy link
Member

igungor commented Jul 18, 2023

@denizsurmeli please update the changelog.

igungor
igungor previously approved these changes Jul 20, 2023
go.mod Show resolved Hide resolved
@seruman
Copy link
Member

seruman commented Jul 20, 2023

Not related to this PR;
https://github.com/peak/s5cmd/actions/runs/5608257848/jobs/10260392004

#582 introduced flakiness on Windows on cp tests.

seruman
seruman previously approved these changes Jul 20, 2023
@igungor igungor merged commit ac09d28 into peak:master Jul 24, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CONTENT DISPOSITION
3 participants