Feat presign #634
Merged
Feat presign #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igungor
reviewed
Aug 11, 2023
Comment on lines
+570
to
+571
| url, err := req.Presign(expire) | ||
| return url, err |
There was a problem hiding this comment.
You may return directly here: return req.Presign(expire).
|
|
||
| func validatePresignCommand(c *cli.Context) error { | ||
| if c.Args().Len() != 1 { | ||
| return fmt.Errorf("expected only one argument") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("expected only one argument") | |
| return fmt.Errorf("expected a remote object url") |
igungor
reviewed
Aug 11, 2023
| @@ -558,6 +558,19 @@ func (s *S3) Read(ctx context.Context, src *url.URL) (io.ReadCloser, error) { | |||
| return resp.Body, nil | |||
| } | |||
|
|
|||
| // Presign fetches the remote object url and returns its. | |||
There was a problem hiding this comment.
You may remove the comment altogether.
|
@zemul It'd be great to have a testcase for this command. You may take a look at |
|
I'll go ahead and merge this PR without waiting for the OP because it's a useful feature and the more we wait, the more this PR will receive conflicts. I'll apply the changes myself later. |
igungor
approved these changes
Aug 21, 2023
seruman
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to share object urls.