use the modern constructor #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bumps the required PHP version from 4.3 to 5.0. The package2.xml and composer.json should be updated. Presumably this is done for PHP 7 support, it may make sense to update the method signatures and class properties to use PHP 5 syntax as well. |
|
in my case i already have problems with php 5.6... and since i don't think that anybody still using php4 will be updating any code (or at least: i hope that nobody is doing so!) i hope that the patch will get accepted... |
|
ok for me |
|
If the package2.xml and composer.json are updated, will this get accepted? |
|
|
Solved in PR #3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should work (better or only) on any somehow runnable php...