missing LICENSE make redistribution impossible #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicollet
changed the title
Closed
| @@ -36,6 +36,8 @@ | |||
| </notes> | |||
| <contents> | |||
| <dir baseinstalldir="/" name="/"> | |||
| <file name="LICENSE" role="doc" /> | |||
| <file name="README.rst" role="doc" /> | |||
There was a problem hiding this comment.
README.rst is just a symlink to docs/guide.txt, so I don't think we need to include it in the package twice.
We could make README.rst the canonical file and get rid of the docs/guide.txt file entirely, though.
jparise
added a commit
that referenced
this pull request
Aug 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing LICENSE make downstream redistribution of this package impossible as, from PHP License term
Please also apply in 1.x branch