Fix Deprecated: Creation of dynamic property + loops for $matches #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloCkWeRX
reviewed
Sep 4, 2023
CloCkWeRX
reviewed
Sep 4, 2023
CloCkWeRX
reviewed
Sep 4, 2023
Fixes (PHP7.4.X): Deprecated: Creation of dynamic property Text_Diff_Engine_native::$xchanged is deprecated .../yii\framework\gii\components\Pear\Text\Diff\Engine\native.php on line 41 Copied from https://github.com/WordPress/WordPress/blob/master/wp-includes/Text/Diff/Engine/native.php. Similar fix as https://github.com/mdeweerd/yii/blob/mdw/framework/gii/components/Pear/Text/Diff/Engine/native.php#L32-L40 . Also copied extra fix replacing loop over list(). Applied `phpcbf --standard=PEAR native.php` resulting in some code formatting changes.
|
I rebased this PR to the master branch. |
marcovtwout
added a commit
to yiisoft/yii
that referenced
this pull request
Sep 27, 2023
…on of dynamic property Text_Diff_Engine_native::$xchanged is deprecated" on PHP 8.2
|
This PR fixes yiisoft/yii#4534 |
|
Can you review the failed tests, and if it's a matter of dropping support for those old versions of PHP, set an appropriate min version/remove them from the suite> |
|
I removed testing the versions <PHP5.6 and added PHP8.0 to PHP8.3 . IMHO the versions <PHP5.6 fail because the environment/include paths would need to be defined differently. Except for the .travis.yml file which seems unused, I could not find other original files where the minimum version is mentionned. |
CloCkWeRX
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (PHP7.4.X): Deprecated: Creation of dynamic property Text_Diff_Engine_native::$xchanged is deprecated .../yii\framework\gii\components\Pear\Text\Diff\Engine\native.php on line 41
Copied from https://github.com/WordPress/WordPress/blob/master/wp-includes/Text/Diff/Engine/native.php. Similar fix as https://github.com/mdeweerd/yii/blob/mdw/framework/gii/components/Pear/Text/Diff/Engine/native.php#L32-L40 .
Also copied extra fix replacing loop over list().
Applied
phpcbf --standard=PEAR native.phpresulting in some code formatting changes.FYI: https://github.com/WordPress/WordPress/blob/master/wp-includes/Text/Diff/Renderer/inline.php seems has some functional changes that might be worth considering upstream.