Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for checkRepo #4

Merged
merged 3 commits into from
May 21, 2013
Merged

Add tests for checkRepo #4

merged 3 commits into from
May 21, 2013

Conversation

vinc
Copy link
Collaborator

@vinc vinc commented May 11, 2013

Add basic tests for checkRepo().

@pearkes
Copy link
Owner

pearkes commented May 11, 2013

Nice! Do you think we can DRY this up a bit for future tests? I feel like we'll be doing it a lot in other places as well.

For example, maybe we can have functions in configuration_test.go that we use to set-up the test environment that we also use in repositories_test.go. Does that make sense? Food for thought.

I'll work on getting a CI set-up as well.

FullName: "alice/example",
SSHUrl: tempDir + "/test",
HTTPSUrl: tempDir + "/test",
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, maybe we can make a makeTestRepo function in this file...then use it wherever we need it in other tests?

@pearkes pearkes mentioned this pull request May 11, 2013
@vinc
Copy link
Collaborator Author

vinc commented May 12, 2013

Yes it makes perfect sense, before adding more tests we'll need to break down this one into smaller reusable components.

But there is probably an existing module built on top of testingthat is offering test fixtures like setUp and tearDown for this purpose.

@pearkes
Copy link
Owner

pearkes commented May 12, 2013

Definitely. 👍

I'm sure that library has something in it.

pearkes added a commit that referenced this pull request May 21, 2013
Add tests for checkRepo
@pearkes pearkes merged commit 8f370f6 into master May 21, 2013
@pearkes pearkes deleted the f-tests branch May 21, 2013 07:19
@pearkes
Copy link
Owner

pearkes commented May 21, 2013

Merging the tests into master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants