Fix dialyzer errors stemming from mis-specced functions with new sub parameter
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoNZooo
changed the title
sub parameter
GoNZooo
changed the title
sub parametersub parameter
|
Thanks! I'll get a new version pushed to hex.pm soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new sub parameter for a few of the
Tokenfunctions has a default value ofnil, but this wasn't reflected in the type spec. This meant that dialyzer simply concluded that the function could never finish and so anything that used these functions simply propagated that.I noticed this because entire trees of execution in one of our projects were marked as having no local return, so this error bubbles up to the top, making dialyzer effectively useless for whatever uses `Goth .
This also addresses #31